Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SizeSelector schema #1611

Merged
merged 25 commits into from
Jun 16, 2021
Merged

Update SizeSelector schema #1611

merged 25 commits into from
Jun 16, 2021

Conversation

jawira
Copy link
Contributor

@jawira jawira commented Jun 12, 2021

I removed unit property from SizeSelector schema to reflect changes made in #1482

Also, unit property was already removed from doc https://www.phing.info/guide/chunkhtml/Size.html

@codecov
Copy link

codecov bot commented Jun 12, 2021

Codecov Report

Merging #1611 (807d288) into main (9bd4e47) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1611   +/-   ##
=========================================
  Coverage     56.84%   56.84%           
  Complexity     6914     6914           
=========================================
  Files           354      354           
  Lines         16748    16748           
=========================================
  Hits           9520     9520           
  Misses         7228     7228           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bd4e47...807d288. Read the comment docs.

@siad007 siad007 added the cleanup code cleanup label Jun 16, 2021
@siad007 siad007 added this to the 3.0.0-RC2 milestone Jun 16, 2021
@siad007
Copy link
Member

siad007 commented Jun 16, 2021

@jawira thx

@siad007 siad007 merged commit 48ae314 into phingofficial:main Jun 16, 2021
@jawira jawira deleted the update-rng branch November 23, 2021 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup code cleanup
Development

Successfully merging this pull request may close these issues.

2 participants